Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect comparison (#54834) #55094

Merged
merged 1 commit into from
Jul 9, 2021
Merged

Fix incorrect comparison (#54834) #55094

merged 1 commit into from
Jul 9, 2021

Conversation

petrogavriluk
Copy link
Contributor

Fix #54834
Add test to check fix.

@petrogavriluk
Fix incorrect comparison (dotnet#54834)
4aa51fe 
Add test to check fix.

Checking comparison result against 1 or -1 causes problems when custom comparer is used.
As a result Min and Max properties return incorrect values.
@ghost
Copy link

ghost commented Jul 2, 2021

Tagging subscribers to this area: @eiriktsarpalis
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #54834
Add test to check fix.

Author: petrogavriluk
Assignees: -
Labels:

area-System.Collections
Milestone: -

@dnfadmin
Copy link

dnfadmin commented Jul 2, 2021 •
edited
Loading

CLA assistant check
All CLA requirements met.

stephentoub
stephentoub approved these changes Jul 2, 2021
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@petrogavriluk
Copy link
Contributor Author

It's my first PR here. Should I do something to pass these failing checks?

@stephentoub
Copy link
Member

Nope, looks like a CI hiccup. I've rerun those legs.

@stephentoub stephentoub merged commit 784ddf8 into dotnet:main Jul 9, 2021
@stephentoub
Copy link
Member

Thanks!

@petrogavriluk petrogavriluk deleted the TreeSubset_MinMax_fix branch July 18, 2021 13:32
@ManickaP ManickaP mentioned this pull request Jul 20, 2021
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

Assignees
No one assigned
Labels
area-System.Collections
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TreeSubSet.Min and TreeSubSet.Max work incorrectly with custom comparer
3 participants
@petrogavriluk @dnfadmin @stephentoub